Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gemfiles to manage dev/test dependencies + cleanup #1949

Merged
merged 8 commits into from
Sep 24, 2023
Merged

Use Gemfiles to manage dev/test dependencies + cleanup #1949

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b8b6e3
Manage development dependencies with `Gemfile`s
dentarg Sep 16, 2023
0a8ea48
Remove unnecessary sinatra-contrib dev deps
dentarg Sep 16, 2023
4735681
Remove Gemfile groups, it is all test/dev deps
dentarg Sep 16, 2023
6871ce5
Remove open-ended dependencies in gemspecs
dentarg Sep 16, 2023
e3b82c0
Document `yard` dependency
dentarg Sep 22, 2023
10b9b5c
Remove `activesupport` from Gemfile
dentarg Sep 22, 2023
6857f5d
Remove `json` from Gemfile
dentarg Sep 22, 2023
607cb3a
Remove `jar-dependencies` from Gemfile
dentarg Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove open-ended dependencies in gemspecs 
To silence warnings from RubyGems.

These are the first published versions of these gems, so the change
should still allow any version to be used.

https://rubygems.org/gems/base64/versions
https://rubygems.org/gems/multi_json/versions
  • Loading branch information
@dentarg
dentarg committed Sep 16, 2023
commit 6871ce5c0b592d45911c82cb075c8bb2947347a3
2 changes: 1 addition & 1 deletion rack-protection/rack-protection.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ RubyGems 2.0 or newer is required to protect against public gem pushes. You can
s.required_ruby_version = '>= 2.6.0'

# dependencies
s.add_dependency 'base64'
s.add_dependency 'base64', '>= 0.1.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still open-ended 😄 (same with multi_json in sinatra-contrib)

Not sure we need to act, hopefully conservative gems that don't change the API anytime soon (if ever?)

s.add_dependency 'rack', '~> 2.2', '>= 2.2.4'
end
2 changes: 1 addition & 1 deletion sinatra-contrib/sinatra-contrib.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ RubyGems 2.0 or newer is required to protect against public gem pushes. You can

s.required_ruby_version = '>= 2.6.0'

s.add_dependency 'multi_json'
s.add_dependency 'multi_json', '>= 0.0.2'
s.add_dependency 'mustermann', '~> 3.0'
s.add_dependency 'rack-protection', version
s.add_dependency 'sinatra', version
Expand Down