break: Drop "Less" templating support #1718
Conversation
olleolleolle
force-pushed
the
drop-less
branch
from
dd7fe8e to
f0a4657
Compare
|
@epergo Is there more than master and stable? Update: found it! |
|
@zzak 👋 I hope this fits the "unstable" branch. |
|
I looked through the results when tested against ruby-head, and don't entirely understand why the tests are failing. One looks like a Nokogiri issue where there's a missing trailing Is a failure of this sort against ruby-head (which isn't stable anyway) a reason not to merge the changes? |
|
@olleolleolle would you mind resolving these conflicts and we'll get this merged 👍 I think you'll just need to rebase unstable. |
|
@jkowens Thanks for letting me know! |
|
I made an abortive attempt using a formatting-happy solargraph'd vim installation, and then I decided to try the GitHub resolution tool. I'll make a try rebasing the branch now, that the conflict is resolved. Update: rebased. |
This removes the support for the defunct Less templating library, and removes the therubyracer dependency, which was used to run tests for it. See sinatra#1716, sinatra#1715 for more discussion and background.
olleolleolle
force-pushed
the
drop-less
branch
from
0ec7f74 to
808e6fd
Compare
|
@jkowens Thanks a lot for moving forward on this! |
This PR removes the support for the defunct Less templating library, and removes the therubyracer dependency, which was used to run tests for it.
See #1716, #1715 for more discussion and background.
Details
This will get us to the position where Ruby 3.1 (ruby-head) can install, but has some failing tests (unrelated to the Less templating library, and to therubyracer gem.)
TODO: