@jkowens Could you take a look?

Looks good to me, except that Falcon server doesn't shutdown gracefully like our other Rack servers when hitting ctrl + c:

/lib/sinatra/base.rb:1478:in `quit!': undefined method `stop' for #<Falcon::Server:0x00007f9729945620> (NoMethodError)

@horaciob is there a way to make that work?

They have some issues related to gracefull (shutdown and restart), let me see if are related with this or i can do something to avoid this.

Who is calling stop on SIGINT?

Any progress?

This is the problem code:

https://github.com/sinatra/sinatra/blob/master/lib/sinatra/base.rb#L1481-L1489

It assumes the server responds to #stop. So, for this to work, either we need to realise not all servers respond to stop! or stop and write a wrapper which invokes the correct method, or we need to add #stop to Falcon::Server some how.

Replaced by #1794