Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop thin support #1627

Merged
merged 7 commits into from
Aug 8, 2020
Merged

Drop thin support #1627

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b989bda
Use puma instead of thin in examples.
rkmathi Jul 26, 2020
559f01a
Remove thin? and add rainbows? in integration_test.
rkmathi Jul 26, 2020
7cec4e9
Remove thin in settings_test.
rkmathi Jul 26, 2020
6073462
Remove thin in lib.
rkmathi Jul 26, 2020
c0d4dd7
Use puma or rainbows instead of thin in readme.
rkmathi Jul 26, 2020
965c8b9
Create integration_async_test for to be enable test with rainbows
rkmathi Aug 4, 2020
7a96472
Run examples/stream.ru with rainbows.
rkmathi Aug 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove thin? and add rainbows? in integration_test.
  • Loading branch information
@rkmathi
rkmathi committed Jul 28, 2020
commit 559f01a295814f3de6847960705a3b24d5600aa1
6 changes: 3 additions & 3 deletions test/integration_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def command
file, dir = RbConfig::CONFIG.values_at('ruby_install_name', 'bindir')
cmd << File.expand_path(file, dir).inspect
end
cmd << "-w" unless thin? || net_http_server?
cmd << "-w" unless net_http_server?
cmd << "-I" << File.expand_path('../../lib', __FILE__).inspect
cmd << app_file.inspect << '-s' << server << '-o' << '127.0.0.1' << '-p' << port
cmd << "-e" << environment.to_s << '2>&1'
Expand All @@ -73,8 +73,8 @@ def webrick?
name.to_s == "webrick"
end

def thin?
name.to_s == "thin"
def rainbows?
name.to_s == "rainbows"
end

def puma?
Expand Down
4 changes: 2 additions & 2 deletions test/integration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class IntegrationTest < Minitest::Test
end

it 'streams async' do
next unless server.thin?
next unless server.rainbows?

Timeout.timeout(3) do
chunks = []
Expand All @@ -58,7 +58,7 @@ class IntegrationTest < Minitest::Test
end

it 'streams async from subclass' do
next unless server.thin?
next unless server.rainbows?

Timeout.timeout(3) do
chunks = []
Expand Down