Use inline conditional instead of Object#try #1485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I'm correct these two lines are the only reason active support is a dependency of sinatra-contrib. If so this change adds 10 bytes source code to get rid of 5MB dependencies.
Non-tested - I only searched for uses on GitHub ...
mwpastore
reviewed
Oct 17, 2018
mwpastore
reviewed
Oct 17, 2018
|
Thanks @mwpastore for your quick reply! Sorry for storming in without checking for earlier pull requests - saw active support pulled in when updating Sinatra, went straight to the source and found it still there without obvious reason. Kind of you to provide the feedback even when this pull request is a duplicate. Feel free to close it if #1448 is about to be merged (with or without the change to #respond_to?). |
|
This can be closed now that #1448 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm correct these two lines are the only reason ActiveSupport is a dependency of sinatra-contrib. If so this change adds 10 bytes source code to get rid of 5MB dependencies.