Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sinatra::RequiredParams implementation #1431

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Fix Sinatra::RequiredParams implementation #1431

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df87572
Contrib: add an example to required params spec
arpitchauhan May 28, 2018
55858e6
Contrib: fix required params implementation
arpitchauhan May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Contrib: add an example to required params spec 
Ensures that required_params doesn't fail
abruptly when a key in params it expected
to be a hash turns out to not be.

It fails currently.
  • Loading branch information
@arpitchauhan
arpitchauhan committed May 28, 2018
commit df87572b0d10e07729deddc4d267489636d1761d
4 changes: 4 additions & 0 deletions sinatra-contrib/spec/required_params_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@
get('/', :p1 => 1, :p2 => {:p21 => 21})
expect(last_response.status).to eq(200)
end
it 'return 400 if p2 is not a hash' do
get('/', :p1 => 1, :p2 => 2)
expect(last_response.status).to eq(400)
end
end
context "complex keys" do
before do
Expand Down