Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with ruby 2.3's --enable-frozen-string-literal #1085

Closed
wants to merge 1 commit into from

Conversation

jeremyevans
Copy link
Contributor

These changes are the minimal ones necessary to allow AutoForme's specs
to pass. There may well be other changes that are required.

These changes are the minimal ones necessary to allow AutoForme's specs
to pass. There may well be other changes that are required.
@zzak
Copy link
Member

zzak commented Jan 29, 2016

@jeremyevans Did you see #1076? I'm not sure how I feel about it.

@jeremyevans
Copy link
Contributor Author

Adding the frozen string literal pragma to files may cause some backwards compatibility issues, though they are unlikely and easy to fix if they do occur. However, changing '' to String.new so that --enable-frozen-string-literal works is a good idea even if you don't add that pragma.

I'm going to close this ticket, as #1076 is more comprehensive. If you think #1076 goes too far, you can always merge it and remove the pragma calls. Sorry for not checking for existing pull requests first. I've been filing many similar issues in other dependencies of my gems and this is the first time that the issue has already been addressed by an existing pull request.

@zzak
Copy link
Member

zzak commented Jan 31, 2016

@jeremyevans No worries bro, thanks for your feedback and contribution!! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants