Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change CHANGES to CHANGELOG.md #1042

Closed
ashleygwilliams opened this issue Oct 28, 2015 · 5 comments
Closed

change CHANGES to CHANGELOG.md #1042

ashleygwilliams opened this issue Oct 28, 2015 · 5 comments
Labels
docs good first issue

Comments

@ashleygwilliams
Copy link
Member

move the file and update the CONTRIBUTING.md doc.
@ashleygwilliams
Copy link
Member Author

anything else that would need to happen for this @TrevorBramble ?

@ashleygwilliams ashleygwilliams changed the title change CHANGE to CHANGELOG.md change CHANGES to CHANGELOG.md Oct 28, 2015
@TrevorBramble
Copy link
Contributor

@ashleygwilliams The release task references the file directly.

sinatra/Rakefile

Line 185 in 52b9a79

if File.binread("CHANGES") =~ /= \d\.\d\.\d . not yet released$/i

@ashleygwilliams
Copy link
Member Author

cool @TrevorBramble !! anyone who address this issue should also be sure to change in that file! let us know if you need help!

@Zemmiph0bia Zemmiph0bia mentioned this issue Oct 28, 2015
Merged
@kimroen
Copy link

kimroen commented Oct 31, 2015

This issue seems to be fixed by #1043, so it can probably be closed. (Thanks, @Zemmiph0bia!)

@kytrinyx
Copy link
Contributor

good call, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TrevorBramble @kytrinyx @kimroen @ashleygwilliams