avoid executing filters even if prefix matches with other namespace

Fixes #1251
sinatra · Feb 9, 2017 · 2d172e5 · 2d172e5
1 parent 32f416c
commit 2d172e5
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/sinatra-contrib/lib/sinatra/namespace.rb b/sinatra-contrib/lib/sinatra/namespace.rb
@@ -333,7 +333,7 @@ def prefixed_path(a, b)
       end
 
       def prefixed(method, pattern = nil, conditions = {}, &block)
-        default = /.*/ if method == :before or method == :after
+        default = %r{(?:/.*)?} if method == :before or method == :after
         pattern, conditions = compile pattern, conditions, default
         result = base.send(method, pattern, conditions, &block)
         invoke_hook :route_added, method.to_s.upcase, pattern, block

diff --git a/sinatra-contrib/spec/namespace_spec.rb b/sinatra-contrib/spec/namespace_spec.rb
@@ -787,5 +787,36 @@ class CError < StandardError;
       expect(get('/foo/bar').status).to eq(200)
       expect(last_response.body).to eq('true')
     end
+
+    it 'avoids executing filters even if prefix matches with other namespace' do
+      mock_app do
+        helpers do
+          def dump_args(*args)
+            args.inspect
+          end
+        end
+
+        namespace '/foo' do
+          helpers do
+            def dump_args(*args)
+              super(:foo, *args)
+            end
+          end
+          get('') { dump_args }
+        end
+
+        namespace '/foo-bar' do
+          helpers do
+            def dump_args(*args)
+              super(:foo_bar, *args)
+            end
+          end
+          get('') { dump_args }
+        end
+      end
+
+      get '/foo-bar'
+      expect(last_response.body).to eq('[:foo_bar]')
+    end
   end
 end