Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update various broken source/guidelines links #11901

Open
uncenter opened this issue Sep 30, 2024 · 3 comments
Open

Update various broken source/guidelines links #11901

uncenter opened this issue Sep 30, 2024 · 3 comments
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both

Comments

@uncenter
Copy link
Member

uncenter commented Sep 30, 2024 •
edited by service-paradis
Loading

I ran a link checker (https://github.com/lycheeverse/lychee) on our data file, combed through to eliminate the false positives, and did a little investigation into each to see if there was an easy new link to use. I ended up with 161 links, many of which have little notes. I'll plan to fix the ones with notes in a large batch PR later, the rest will still need have sources/new links tracked down. The following list was generated from a little script I made, so my apologies if a link is incorrectly associated with the wrong icon!

Format is the following:

  • [icon-title]: [broken-link(s)]
    • [optional-note]

Note

Some sites, mostly the .fr ones iirc, I was not able to access. Those may be false positives if it is just my network or location that prevents be from accessing?
@uncenter uncenter added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Sep 30, 2024
@uncenter uncenter mentioned this issue Sep 30, 2024
Closed
@uncenter uncenter mentioned this issue Oct 11, 2024
Closed
@Nyveon
Copy link

Nyveon commented Oct 12, 2024

I ran into a broken link just now (redirects to homepage), if you could add it to the list c:

@uncenter uncenter mentioned this issue Oct 13, 2024
Merged
@uncenter uncenter added the good first issue Issues we believe are simple and a good first stab at contributing to the project label Nov 11, 2024
@uncenter uncenter mentioned this issue Nov 21, 2024
Merged
This was referenced Nov 26, 2024
Merged
Merged
Merged
@mondeja mondeja pinned this issue Nov 26, 2024
This was referenced Nov 26, 2024
Draft
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@adamrusted
Copy link
Member

adamrusted commented Dec 12, 2024 •
edited
Loading

Updated CentOS icons are available here as referenced in their official icons repository, however the newly discovered repo specifically states no license is granted, except for 'average use of the software' - so we may need to remove. Damn Red Hat and their licensing!

@achoo-o achoo-o mentioned this issue Dec 24, 2024
Open
@ohansFavour ohansFavour mentioned this issue Jan 1, 2025
Open
3 tasks
@LitoMore
Copy link
Member

LitoMore commented Jan 2, 2025

To contributors who want to work on this issue. Please check these below before submitting your PR:

  1. Please confirm that those links have source files that can be used as references?
  2. When the source changes, you should also check whether the new source files are consistent with the current icons.

Here is how do I review differences so that you can check the difference locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adamrusted @LitoMore @uncenter @Nyveon