Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image to image vae compile demo #406

Merged
merged 2 commits into from
Dec 11, 2023
Merged

add image to image vae compile demo #406

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b16e09e
add image to image controlnet
strint Dec 7, 2023
7c3196d
Update examples/image_to_image_controlnet.py
strint Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update examples/image_to_image_controlnet.py
  • Loading branch information
@strint
strint authored Dec 7, 2023
commit 7c3196d88a0ae4b12ab84937201a08ed1a101564
2 changes: 1 addition & 1 deletion examples/image_to_image_controlnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
if args.compile_vae:
from onediff.infer_compiler import oneflow_compile
#pipe.vae = oneflow_compile(pipe.vae)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related work takes my time: #394

But it's not trivial to compile the encode and decode in one graph.

# ImageToImage has encoder and decoder, so we need to compile them seperately.
# ImageToImage has an encoder and decoder, so we need to compile them separately.
pipe.vae.encoder = oneflow_compile(pipe.vae.encoder)
pipe.vae.decoder = oneflow_compile(pipe.vae.decoder)
Copy link
Collaborator Author

@strint strint Dec 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile the encoder and decoder separately

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an automatic way to detect and report the cause of inappropriately compiling encoder and decoder together?

Copy link
Collaborator Author

@strint strint Dec 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an automatic way to detect and report the cause of inappropriately compiling encoder and decoder together?

Yes, we are working on it in another PR: directly compile the full vae.


Expand Down
Loading