Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue and pull request templates #735

Closed
wants to merge 1 commit into from

Conversation

2-4601
Copy link
Contributor

@2-4601 2-4601 commented Mar 29, 2016

Contributor checklist

  • My changes are rebased on the latest master branch
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these platforms:
    • Ubuntu 15.10, Chrome 49.0.2623.110
    • Ubuntu 15.10, Firefox 45.0
  • My commits are in nice logical chunks
  • I followed the best practices when writing my commit messages
  • I have made the choice whether I want the Bithub reward or not by omitting or adding the word FREEBIE in my commit message

Description

Dis been iterated at the Android repo

Issue template
PR template
  • clarify how to fill checkboxes
  • more about tests
  • add link to an explanation for BitHub rewards (this has caused confusion before)
  • explain that failing Travis CI build checks are normal
  • other small stuff

Issue template
 - more explanations and tips
 - clarify how to fill checkboxes
 - actual and expected results
 - remove link to the community forum

PR template
 - clarify how to fill checkboxes
 - more about tests
 - add a link to an explanation for BitHub rewards
 - explain that failing Travis CI build checks are normal

Closes signalapp#735

// FREEBIE
@liliakai liliakai closed this in 27dc620 Apr 7, 2016
@2-4601 2-4601 deleted the templates branch April 8, 2016 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant