Update Sonar issue identifiers: 'squid' becomes 'java'

sidohaakma · Feb 12, 2020 · d939af3 · d939af3
1 parent 5f5a319
commit d939af3
Show file tree

Hide file tree

Showing 328 changed files with 348 additions and 464 deletions.
diff --git a/...on-bucket/src/test/java/org/molgenis/amazon/bucket/meta/AmazonBucketJobExecutionTest.java b/...on-bucket/src/test/java/org/molgenis/amazon/bucket/meta/AmazonBucketJobExecutionTest.java
@@ -47,7 +47,7 @@ protected List<String> getExcludedAttrs() {
     return attrs;
   }
 
-  @SuppressWarnings("squid:S2699") // Tests should include assertions
+  @SuppressWarnings("java:S2699") // Tests should include assertions
   @Test
   protected void testSystemEntity() {
     internalTestAttributes(

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/CopyEntityRequestV2.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/CopyEntityRequestV2.java
@@ -6,8 +6,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_CopyEntityRequestV2.class)
-@SuppressWarnings(
-    "squid:S1610") // Abstract classes without fields should be converted to interfaces
+@SuppressWarnings("java:S1610") // Abstract classes without fields should be converted to interfaces
 public abstract class CopyEntityRequestV2 {
   @NotNull
   public abstract String getNewEntityName();

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/EntityCollectionBatchRequestV2.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/EntityCollectionBatchRequestV2.java
@@ -9,8 +9,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_EntityCollectionBatchRequestV2.class)
-@SuppressWarnings(
-    "squid:S1610") // Abstract classes without fields should be converted to interfaces
+@SuppressWarnings("java:S1610") // Abstract classes without fields should be converted to interfaces
 public abstract class EntityCollectionBatchRequestV2 {
   @NotEmpty(message = "Please provide at least one entity in the entities property.")
   @Size(

diff --git a/...enis-api-data/src/main/java/org/molgenis/api/data/v2/EntityCollectionDeleteRequestV2.java b/...enis-api-data/src/main/java/org/molgenis/api/data/v2/EntityCollectionDeleteRequestV2.java
@@ -8,8 +8,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_EntityCollectionDeleteRequestV2.class)
-@SuppressWarnings(
-    "squid:S1610") // Abstract classes without fields should be converted to interfaces
+@SuppressWarnings("java:S1610") // Abstract classes without fields should be converted to interfaces
 public abstract class EntityCollectionDeleteRequestV2 {
   @NotEmpty(message = "Please provide at least one entity in the entityIds property.")
   @Size(

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/ResourcesResponseV2.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/ResourcesResponseV2.java
@@ -6,8 +6,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_ResourcesResponseV2.class)
-@SuppressWarnings(
-    "squid:S1610") // Abstract classes without fields should be converted to interfaces
+@SuppressWarnings("java:S1610") // Abstract classes without fields should be converted to interfaces
 public abstract class ResourcesResponseV2 {
   @NotNull
   public abstract String getHref();

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/RestControllerV2.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v2/RestControllerV2.java
@@ -303,7 +303,7 @@ public AttributeResponseV2 retrieveEntityAttributeMetaPost(
    * @param response HttpServletResponse
    * @return EntityCollectionCreateResponseBodyV2
    */
-  @SuppressWarnings("squid:S2259") // getEntities is guaranteed to be not empty
+  @SuppressWarnings("java:S2259") // getEntities is guaranteed to be not empty
   @Transactional
   @PostMapping(value = "/{entityTypeId}", produces = APPLICATION_JSON_VALUE)
   public EntityCollectionBatchCreateResponseBodyV2 createEntities(
@@ -428,7 +428,7 @@ public String copyEntity(
    * @param request EntityCollectionCreateRequestV2
    * @param response HttpServletResponse
    */
-  @SuppressWarnings("squid:S2259") // getEntities is guaranteed to be not empty
+  @SuppressWarnings("java:S2259") // getEntities is guaranteed to be not empty
   @Transactional
   @PutMapping("/{entityTypeId}")
   public synchronized void updateEntities(
@@ -481,7 +481,7 @@ public Map<String, String> getL10nStrings() {
    * @param request EntityCollectionBatchRequestV2
    * @param response HttpServletResponse
    */
-  @SuppressWarnings("squid:S2259") // getEntities is guaranteed to be not empty
+  @SuppressWarnings("java:S2259") // getEntities is guaranteed to be not empty
   @Transactional
   @PutMapping("/{entityTypeId}/{attributeName}")
   @ResponseStatus(OK)

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/Entities.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/Entities.java
@@ -19,7 +19,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/EntityCollection.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/EntityCollection.java
@@ -22,7 +22,7 @@ int getSize() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   abstract static class Builder {
 
@@ -72,7 +72,7 @@ static Builder builder() {
     }
 
     @SuppressWarnings(
-        "squid:S1610") // Abstract classes without fields should be converted to interfaces
+        "java:S1610") // Abstract classes without fields should be converted to interfaces
     @AutoValue.Builder
     abstract static class Builder {
 

diff --git a/...is-api-data/src/main/java/org/molgenis/api/data/v3/UnsupportedAttributeTypeException.java b/...is-api-data/src/main/java/org/molgenis/api/data/v3/UnsupportedAttributeTypeException.java
@@ -4,7 +4,7 @@
 import org.molgenis.data.meta.model.Attribute;
 import org.molgenis.util.exception.BadRequestException;
 
-@SuppressWarnings("squid:MaximumInheritanceDepth")
+@SuppressWarnings("java:MaximumInheritanceDepth")
 public class UnsupportedAttributeTypeException extends BadRequestException {
   private static final String ERROR_CODE = "DAPI01";
 

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/model/EntitiesResponse.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/model/EntitiesResponse.java
@@ -37,7 +37,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/model/EntityResponse.java b/molgenis-api-data/src/main/java/org/molgenis/api/data/v3/model/EntityResponse.java
@@ -26,7 +26,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/molgenis-api-identities/src/main/java/org/molgenis/api/identities/AddGroupMemberCommand.java b/molgenis-api-identities/src/main/java/org/molgenis/api/identities/AddGroupMemberCommand.java
@@ -5,7 +5,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_AddGroupMemberCommand.class)
-@SuppressWarnings("squid:S1610")
+@SuppressWarnings("java:S1610")
 public abstract class AddGroupMemberCommand {
   public abstract String getUsername();
 

diff --git a/molgenis-api-identities/src/main/java/org/molgenis/api/identities/GroupCommand.java b/molgenis-api-identities/src/main/java/org/molgenis/api/identities/GroupCommand.java
@@ -5,7 +5,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_GroupCommand.class)
-@SuppressWarnings("squid:S1610")
+@SuppressWarnings("java:S1610")
 public abstract class GroupCommand {
   public abstract String getName();
 

diff --git a/molgenis-api-identities/src/main/java/org/molgenis/api/identities/GroupMemberResponse.java b/molgenis-api-identities/src/main/java/org/molgenis/api/identities/GroupMemberResponse.java
@@ -4,7 +4,7 @@
 import org.molgenis.data.security.auth.RoleMembership;
 
 @AutoValue
-@SuppressWarnings("squid:S1610")
+@SuppressWarnings("java:S1610")
 public abstract class GroupMemberResponse {
   public abstract UserResponse getUser();
 

diff --git a/molgenis-api-identities/src/main/java/org/molgenis/api/identities/GroupResponse.java b/molgenis-api-identities/src/main/java/org/molgenis/api/identities/GroupResponse.java
@@ -4,7 +4,7 @@
 import org.molgenis.data.security.auth.Group;
 
 @AutoValue
-@SuppressWarnings("squid:S1610")
+@SuppressWarnings("java:S1610")
 public abstract class GroupResponse {
   public abstract String getName();
 

diff --git a/...nis-api-identities/src/main/java/org/molgenis/api/identities/IdentitiesApiController.java b/...nis-api-identities/src/main/java/org/molgenis/api/identities/IdentitiesApiController.java
@@ -50,7 +50,7 @@
 public class IdentitiesApiController {
   public static final String USER = "/user";
 
-  @SuppressWarnings("squid:S1075") // URIs should not be hardcoded
+  @SuppressWarnings("java:S1075") // URIs should not be hardcoded
   private static final String SECURITY_API_PATH = ApiNamespace.API_PATH + "/identities";
 
   static final String GROUP_END_POINT = SECURITY_API_PATH + "/group";

diff --git a/molgenis-api-identities/src/main/java/org/molgenis/api/identities/RoleResponse.java b/molgenis-api-identities/src/main/java/org/molgenis/api/identities/RoleResponse.java
@@ -4,8 +4,7 @@
 import org.molgenis.data.security.auth.Role;
 
 @AutoValue
-@SuppressWarnings(
-    "squid:S1610") // Abstract classes without fields should be converted to interfaces
+@SuppressWarnings("java:S1610") // Abstract classes without fields should be converted to interfaces
 public abstract class RoleResponse {
   public abstract String getRoleName();
 

diff --git a/...is-api-identities/src/main/java/org/molgenis/api/identities/UpdateGroupMemberCommand.java b/...is-api-identities/src/main/java/org/molgenis/api/identities/UpdateGroupMemberCommand.java
@@ -5,7 +5,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_UpdateGroupMemberCommand.class)
-@SuppressWarnings("squid:S1610")
+@SuppressWarnings("java:S1610")
 public abstract class UpdateGroupMemberCommand {
   public abstract String getRoleName();
 

diff --git a/molgenis-api-identities/src/main/java/org/molgenis/api/identities/UpdateIncludeCommand.java b/molgenis-api-identities/src/main/java/org/molgenis/api/identities/UpdateIncludeCommand.java
@@ -5,7 +5,7 @@
 
 @AutoValue
 @AutoGson(autoValueClass = AutoValue_UpdateIncludeCommand.class)
-@SuppressWarnings("squid:S1610")
+@SuppressWarnings("java:S1610")
 public abstract class UpdateIncludeCommand {
 
   public abstract String getRole();

diff --git a/molgenis-api-identities/src/main/java/org/molgenis/api/identities/UserResponse.java b/molgenis-api-identities/src/main/java/org/molgenis/api/identities/UserResponse.java
@@ -4,8 +4,7 @@
 import org.molgenis.data.security.auth.User;
 
 @AutoValue
-@SuppressWarnings(
-    "squid:S1610") // Abstract classes without fields should be converted to interfaces
+@SuppressWarnings("java:S1610") // Abstract classes without fields should be converted to interfaces
 public abstract class UserResponse {
   public abstract String getId();
 

diff --git a/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/Attributes.java b/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/Attributes.java
@@ -19,7 +19,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/EntityTypeCollection.java b/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/EntityTypeCollection.java
@@ -17,7 +17,7 @@ abstract class EntityTypeCollection {
   abstract @Nullable @CheckForNull String getEntityId();
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   abstract static class Builder {
 
@@ -59,7 +59,7 @@ static Builder builder() {
     }
 
     @SuppressWarnings(
-        "squid:S1610") // Abstract classes without fields should be converted to interfaces
+        "java:S1610") // Abstract classes without fields should be converted to interfaces
     @AutoValue.Builder
     abstract static class Builder {
 

diff --git a/...-api-metadata/src/main/java/org/molgenis/api/metadata/v3/EntityTypeRequestMapperImpl.java b/...-api-metadata/src/main/java/org/molgenis/api/metadata/v3/EntityTypeRequestMapperImpl.java
@@ -95,7 +95,7 @@ public void updateEntityType(EntityType entityType, Map<String, Object> entityTy
   }
 
   @SuppressWarnings({
-    "squid:S1192"
+    "java:S1192"
   }) // ATTRIBUTES constant in this class is not related to the one in this switch
   private void updateEntityType(EntityType entityType, Entry<String, Object> entry) {
     switch (entry.getKey()) {

diff --git a/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/EntityTypes.java b/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/EntityTypes.java
@@ -19,7 +19,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...tadata/src/main/java/org/molgenis/api/metadata/v3/exception/EmptyAttributesException.java b/...tadata/src/main/java/org/molgenis/api/metadata/v3/exception/EmptyAttributesException.java
@@ -2,7 +2,7 @@
 
 import org.molgenis.util.exception.BadRequestException;
 
-@SuppressWarnings("squid:MaximumInheritanceDepth")
+@SuppressWarnings("java:MaximumInheritanceDepth")
 public class EmptyAttributesException extends BadRequestException {
   private static final String ERROR_CODE = "MAPI02";
 

diff --git a/...etadata/src/main/java/org/molgenis/api/metadata/v3/exception/IdModificationException.java b/...etadata/src/main/java/org/molgenis/api/metadata/v3/exception/IdModificationException.java
@@ -2,7 +2,7 @@
 
 import org.molgenis.util.exception.BadRequestException;
 
-@SuppressWarnings("squid:MaximumInheritanceDepth")
+@SuppressWarnings("java:MaximumInheritanceDepth")
 public class IdModificationException extends BadRequestException {
 
   private static final String ERROR_CODE = "MAPI03";

diff --git a/...pi-metadata/src/main/java/org/molgenis/api/metadata/v3/exception/InvalidKeyException.java b/...pi-metadata/src/main/java/org/molgenis/api/metadata/v3/exception/InvalidKeyException.java
@@ -5,7 +5,7 @@
 
 import org.molgenis.util.exception.BadRequestException;
 
-@SuppressWarnings("squid:MaximumInheritanceDepth")
+@SuppressWarnings("java:MaximumInheritanceDepth")
 public class InvalidKeyException extends BadRequestException {
   private static final String ERROR_CODE = "MAPI04";
   private final String target;

diff --git a/...metadata/src/main/java/org/molgenis/api/metadata/v3/exception/ReadOnlyFieldException.java b/...metadata/src/main/java/org/molgenis/api/metadata/v3/exception/ReadOnlyFieldException.java
@@ -5,7 +5,7 @@
 
 import org.molgenis.util.exception.BadRequestException;
 
-@SuppressWarnings("squid:MaximumInheritanceDepth")
+@SuppressWarnings("java:MaximumInheritanceDepth")
 public class ReadOnlyFieldException extends BadRequestException {
   private static final String ERROR_CODE = "MAPI07";
   private final String field;

diff --git a/...rc/main/java/org/molgenis/api/metadata/v3/exception/UnknownLookupAttributesException.java b/...rc/main/java/org/molgenis/api/metadata/v3/exception/UnknownLookupAttributesException.java
@@ -8,7 +8,7 @@
 import org.molgenis.data.meta.model.EntityType;
 import org.molgenis.util.exception.BadRequestException;
 
-@SuppressWarnings("squid:MaximumInheritanceDepth")
+@SuppressWarnings("java:MaximumInheritanceDepth")
 public class UnknownLookupAttributesException extends BadRequestException {
 
   private static final String ERROR_CODE = "MAPI05";

diff --git a/...adata/src/main/java/org/molgenis/api/metadata/v3/exception/UnsupportedFieldException.java b/...adata/src/main/java/org/molgenis/api/metadata/v3/exception/UnsupportedFieldException.java
@@ -5,7 +5,7 @@
 
 import org.molgenis.util.exception.BadRequestException;
 
-@SuppressWarnings("squid:MaximumInheritanceDepth")
+@SuppressWarnings("java:MaximumInheritanceDepth")
 public class UnsupportedFieldException extends BadRequestException {
   private static final String ERROR_CODE = "MAPI06";
   private final String field;

diff --git a/...is-api-metadata/src/main/java/org/molgenis/api/metadata/v3/job/SerializableAttribute.java b/...is-api-metadata/src/main/java/org/molgenis/api/metadata/v3/job/SerializableAttribute.java
@@ -106,7 +106,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...s-api-metadata/src/main/java/org/molgenis/api/metadata/v3/job/SerializableEntityType.java b/...s-api-metadata/src/main/java/org/molgenis/api/metadata/v3/job/SerializableEntityType.java
@@ -45,7 +45,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...enis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/AttributeResponse.java b/...enis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/AttributeResponse.java
@@ -27,7 +27,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/AttributeResponseData.java b/...-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/AttributeResponseData.java
@@ -96,7 +96,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to Integererfaces
+      "java:S1610") // Abstract classes without fields should be converted to Integererfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...nis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/AttributesResponse.java b/...nis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/AttributesResponse.java
@@ -37,7 +37,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/Category.java b/molgenis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/Category.java
@@ -17,7 +17,7 @@ public static Builder builder() {
   }
 
   // Abstract classes without fields should be converted to interfaces
-  @SuppressWarnings("squid:S1610")
+  @SuppressWarnings("java:S1610")
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/CreateAttributeRequest.java b/...api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/CreateAttributeRequest.java
@@ -158,7 +158,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...pi-metadata/src/main/java/org/molgenis/api/metadata/v3/model/CreateEntityTypeRequest.java b/...pi-metadata/src/main/java/org/molgenis/api/metadata/v3/model/CreateEntityTypeRequest.java
@@ -57,7 +57,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
 

diff --git a/...nis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/EntityTypeResponse.java b/...nis-api-metadata/src/main/java/org/molgenis/api/metadata/v3/model/EntityTypeResponse.java
@@ -26,7 +26,7 @@ public static Builder builder() {
   }
 
   @SuppressWarnings(
-      "squid:S1610") // Abstract classes without fields should be converted to interfaces
+      "java:S1610") // Abstract classes without fields should be converted to interfaces
   @AutoValue.Builder
   public abstract static class Builder {
     public abstract Builder setLinks(LinksResponse newLinks);