Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement url shortener with postgres and rocket #94

Merged
merged 13 commits into from
Mar 29, 2022
Merged

implement url shortener with postgres and rocket #94

merged 13 commits into from
Mar 29, 2022

Conversation

thecotne
Copy link
Contributor

@thecotne thecotne commented Mar 22, 2022 •
edited
Loading

Copies for this example:

  • Short: URL shortener
  • Long: A URL shortener that you can use from your terminal - built with shuttle, rocket and postgres/sqlx.

@thecotne thecotne marked this pull request as ready for review March 22, 2022 11:09
@thecotne thecotne requested a review from brokad March 22, 2022 11:10
nodard
nodard reviewed Mar 24, 2022
View reviewed changes
Copy link
Contributor

@nodard nodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some language edits

examples/url-shortener/README.md Outdated Show resolved Hide resolved
examples/url-shortener/README.md Outdated Show resolved Hide resolved
examples/url-shortener/README.md Outdated Show resolved Hide resolved
examples/url-shortener/README.md Outdated Show resolved Hide resolved
examples/url-shortener/README.md Outdated Show resolved Hide resolved
examples/url-shortener/README.md Outdated Show resolved Hide resolved
thecotne and others added 6 commits March 24, 2022 16:20
@thecotne @nodard
Update examples/url-shortener/README.md
4bc4232 
Co-authored-by: Nodar Daneliya <NodarD@users.noreply.github.com>
@thecotne @nodard
Update examples/url-shortener/README.md
4bba487 
Co-authored-by: Nodar Daneliya <NodarD@users.noreply.github.com>
@thecotne @nodard
Update examples/url-shortener/README.md
3493209 
Co-authored-by: Nodar Daneliya <NodarD@users.noreply.github.com>
@thecotne @nodard
Update examples/url-shortener/README.md
566875f 
Co-authored-by: Nodar Daneliya <NodarD@users.noreply.github.com>
@thecotne @nodard
Update examples/url-shortener/README.md
99e541b 
Co-authored-by: Nodar Daneliya <NodarD@users.noreply.github.com>
@thecotne @nodard
Update examples/url-shortener/README.md
0131b3e 
Co-authored-by: Nodar Daneliya <NodarD@users.noreply.github.com>
brokad
brokad reviewed Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@brokad brokad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thecotne 😄

examples/url-shortener/schema.sql Outdated Show resolved Hide resolved
examples/url-shortener/src/lib.rs Outdated Show resolved Hide resolved
examples/url-shortener/src/lib.rs Outdated Show resolved Hide resolved
@thecotne thecotne requested a review from brokad March 28, 2022 09:34
brokad
brokad approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@brokad brokad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @thecotne!

@thecotne thecotne merged commit 9ea2407 into main Mar 29, 2022
@chesedo chesedo deleted the feat/url-shortener-example branch October 24, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodard nodard nodard left review comments

@brokad brokad brokad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thecotne @nodard @brokad