Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cargo generate instead of hardcoding examples source code #888

Merged
merged 14 commits into from
Jun 9, 2023
Merged

feat: use cargo generate instead of hardcoding examples source code #888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5d907e9
feat: use `cargo generate` instead of hardcoding examples source code
paulotten May 8, 2023
ccdbea2
Merge branch 'shuttle-hq:main' into paul/cargo_generate
paulotten Jun 6, 2023
e1824e7
feat: use `cargo-generate` as a library
paulotten Jun 6, 2023
b49c285
feat: add `custom/none` example
paulotten Jun 7, 2023
bdb6212
use project name `.as_ref()`
paulotten Jun 7, 2023
07dbbf2
fix: apparently we need to use `auto_path` instead of `subfolder`.
paulotten Jun 7, 2023
bd4551c
chore: update `examples` git submodule
paulotten Jun 7, 2023
aac6948
manually set the crate name
paulotten Jun 7, 2023
001000e
fix: clippy lints
paulotten Jun 7, 2023
2602993
fix: rocket sub path
paulotten Jun 7, 2023
c4a8239
move `use` to top of file
paulotten Jun 7, 2023
65ab862
remove the Shuttle.toml file, if it exists
paulotten Jun 7, 2023
77e7398
Merge branch 'main' into paul/cargo_generate
iulianbarbu Jun 7, 2023
c381487
feat: create a .gitignore file when copying an example
paulotten Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use project name .as_ref()
  • Loading branch information
@paulotten
paulotten committed Jun 7, 2023
commit bdb621298fa8dff75e5ffbbdcde14be633c395a3
2 changes: 1 addition & 1 deletion cargo-shuttle/src/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ impl ShuttleInit for ShuttleInitNoOp {
}
}

pub fn cargo_generate(path: PathBuf, name: ProjectName, framework: Template) -> Result<()> {
pub fn cargo_generate(path: PathBuf, name: &ProjectName, framework: Template) -> Result<()> {
let config = framework.init_config();

println!(r#" Creating project "{name}" in {path:?}"#);
Expand Down
9 changes: 8 additions & 1 deletion cargo-shuttle/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,14 @@ impl Shuttle {
};

// 5. Initialize locally
init::cargo_generate(path.clone(), project_args.name.clone().unwrap(), framework)?;
init::cargo_generate(
path.clone(),
project_args
.name
.as_ref()
.expect("to have a project name provided"),
framework,
)?;
println!();

// 6. Confirm that the user wants to create the project environment on Shuttle
Expand Down