Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployer): split up deployer error enum #339

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Sep 12, 2022

Split up deployer/src/error, since the handlers use almost none of its variants.

Copy link
Collaborator

@brokad brokad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

The two comments I have actually came from code you inherited in the diff!

deployer/src/handlers/error.rs Outdated Show resolved Hide resolved
deployer/src/handlers/error.rs Show resolved Hide resolved
@oddgrd oddgrd force-pushed the feat/deployer-split-error branch from ba2e10b to 6a7b6ba Compare September 16, 2022 14:22
@oddgrd oddgrd merged commit d4bf86c into shuttle-hq:feat/deployer Sep 16, 2022
@oddgrd oddgrd deleted the feat/deployer-split-error branch September 16, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants