Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically set cdylib library type at build time #212

Merged
merged 14 commits into from
Jun 15, 2022
Merged

feat: automatically set cdylib library type at build time #212

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
393ae8e
feat: automatically insert cdylib requirement
bmoxb Jun 10, 2022
6fb964f
refactor: remove 'cdylib' from all examples
bmoxb Jun 10, 2022
9a54c7c
feat: reject non-library projects
bmoxb Jun 10, 2022
4344483
test: fix/add new tests
bmoxb Jun 10, 2022
c64763a
refactor: correcy outdated comment
bmoxb Jun 10, 2022
5a9f527
feat: no longer generate projects with `cdylib` set in `Cargo.toml`
bmoxb Jun 10, 2022
25bcff0
refactor: remove 'cdylib' from tests
bmoxb Jun 10, 2022
ef87969
refactor: cdylib conversion using iter_mut().find
bmoxb Jun 12, 2022
b3737b2
refactor: remove unnecessary imports
bmoxb Jun 12, 2022
c24a397
test: remove 'cdylib' check
bmoxb Jun 12, 2022
c4cc13b
test: restore 'cdylib' specification for tests built outside of loade…
bmoxb Jun 12, 2022
68e4a40
feat: handle virtual manifest, remove unnecessary cdylib built check
bmoxb Jun 12, 2022
07f3a88
docs: remove references to specifying 'cdylib'
bmoxb Jun 13, 2022
92d293a
test: use 'should_panic' to ensure correct error message is produced
bmoxb Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: use 'should_panic' to ensure correct error message is produced
  • Loading branch information
@bmoxb
bmoxb committed Jun 15, 2022
commit 92d293a6f2b5854cc7a82d675b458220cc6b7ad8
5 changes: 4 additions & 1 deletion service/tests/build_crate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,13 @@ fn not_shuttle() {
}

#[test]
#[should_panic(
expected = "Your Shuttle project must be a library. Please add `[lib]` to your Cargo.toml file."
)]
fn not_lib() {
let buf = Box::new(DummyWriter {});
let project_path = format!("{}/tests/resources/not-lib", env!("CARGO_MANIFEST_DIR"));
assert!(build_crate(Path::new(&project_path), buf).is_err());
build_crate(Path::new(&project_path), buf).unwrap();
}

#[test]
Expand Down