Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth, gateway): use user_id over account_name #1674

Merged
merged 27 commits into from
Mar 15, 2024
Merged

refactor(auth, gateway): use user_id over account_name #1674

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
76273d3
feat(auth): user_id not null, remove migration insertions
jonaro00 Mar 8, 2024
28e82d4
fix(auth): insert user_id on command inserts
jonaro00 Mar 8, 2024
877930f
feat: rename account_name to user_id in most places
jonaro00 Mar 8, 2024
e1c20ba
nits
jonaro00 Mar 8, 2024
a816e73
nit2
jonaro00 Mar 8, 2024
5445696
fix: auth tests almost working
jonaro00 Mar 8, 2024
bcde733
yeet: auth/refresh
jonaro00 Mar 8, 2024
3e205d1
fix: span
jonaro00 Mar 8, 2024
00c3162
fix: auth tests
jonaro00 Mar 8, 2024
8caf01b
feat: set old account name header for tracing in old deployers
jonaro00 Mar 8, 2024
617d9c6
nit: clarify start_last_deploy
jonaro00 Mar 8, 2024
c8fe94b
fix: sql comment
jonaro00 Mar 11, 2024
2900c3d
fix: userid comment
jonaro00 Mar 11, 2024
1edf407
feat(deployer): use claim instead of user id header for tracing
jonaro00 Mar 12, 2024
0be50c3
nit: remove request.path tracing field
jonaro00 Mar 12, 2024
0931bf3
Revert "nit: remove request.path tracing field"
jonaro00 Mar 13, 2024
3c27279
less clone
jonaro00 Mar 13, 2024
30a966d
feat(auth): keep get account by name endpoint
jonaro00 Mar 13, 2024
9f0be65
fmt
jonaro00 Mar 13, 2024
f33f9da
ci: unstable
jonaro00 Mar 13, 2024
443cdc8
clippy
jonaro00 Mar 13, 2024
fa81d18
fix: migration drift fixes
jonaro00 Mar 13, 2024
d702495
fix: migration drift fixes 2
jonaro00 Mar 13, 2024
0e8e6ef
revert: migration drift fixes
jonaro00 Mar 14, 2024
51b1c0c
fix: endpoint ordering
jonaro00 Mar 14, 2024
bc82a89
test: set empty field on endpoint
jonaro00 Mar 15, 2024
b312146
Revert "test: set empty field on endpoint"
jonaro00 Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit: remove request.path tracing field
  • Loading branch information
@jonaro00
jonaro00 committed Mar 12, 2024
commit 0be50c3dacf102e530a0da5f6403800ac2f35a13
3 changes: 0 additions & 3 deletions common/src/backends/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ macro_rules! request_span {
http.status_code = tracing::field::Empty,
// A bunch of extra things for metrics
// Should be able to make this clearer once `Valuable` support lands in tracing
request.path = path,
$($field)*
)
}
Expand Down Expand Up @@ -253,7 +252,6 @@ mod tests {
.with_span_field("http.uri")
.with_span_field("http.method")
.with_span_field("http.status_code")
.with_span_field("request.path")
.was_closed()
.finalize();

Expand Down Expand Up @@ -297,7 +295,6 @@ mod tests {
.with_span_field("http.uri")
.with_span_field("http.method")
.with_span_field("http.status_code")
.with_span_field("request.path")
.with_span_field("request.params.user_name")
.with_span_field("extra")
.was_closed()
Expand Down