Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the missing support for creating custom resources #1082

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Added the missing support for creating custom resources #1082

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2648ddf
common: added custom resource type enum variant
iulianbarbu Jul 11, 2023
75909ad
deployer: add support for custom resources
iulianbarbu Jul 11, 2023
4d19e44
deployer: fix FromStr to resource::Type
iulianbarbu Jul 11, 2023
586f5ce
resource-recorder: add custom resource type
iulianbarbu Jul 17, 2023
2826be1
docs: adjust docs to refer to custom-resource examples
iulianbarbu Jul 17, 2023
836182e
P review: remove comment until changing persist info is requested
iulianbarbu Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
P review: remove comment until changing persist info is requested
  • Loading branch information
@iulianbarbu
iulianbarbu committed Jul 17, 2023
commit 836182ea9f42894ddc1a7602cd6a6417a4581172
3 changes: 0 additions & 3 deletions common/src/models/resource.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@ fn get_persist_table(persist_instances: &[&Response], service_name: &str) -> Str
.add_attribute(Attribute::Bold)]);

for _ in persist_instances {
// TODO: add some information that would make the persist resource identifiable.
// This requires changing the backend resource list response to include a resource identifier
// that can be used to query for more info related to a resource.
table.add_row(vec!["Instance"]);
}

Expand Down