-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXIF Orientation not supported #570
Comments
Hi @Yay295 |
I was using |
EXIF is an interesting situation. It's only recently been adopted into the PNG spec (third edition, still not a final standard yet) and as you pointed out is not widely supported yet. EXIF can also contain a huge variety of different metadata and much of the time it is unimportant and perfectly safe to strip. Without adding full EXIF support to oxipng to read and understand the data, we can't know whether it might be "safe" or not. It's certainly a feature we could consider, but it's not a simple matter. My advice for now would be to not use EXIF in pngs in the first place. |
There's the |
Personal opinion: |
If you want to remove all metadata you can use |
Theoretically, you could actually save space by adding an orientation tag if you were able to compress the image better by flipping/rotating it. |
I think we would want more data on this before we can make a call on it. How and why EXIF is being used in pngs, what tags etc. Your report is helpful, but currently it’s the only data point we have. Right now I don’t think it’s a big issue. If you need to preserve it, you can. If you strip it inadvertently, it’s easy enough to restore (unlike some other chunks). |
Yeah, it's not a problem for me. I only noticed it because I added code to my scripts to check for it, so I'm already handling it. I just think it's something that oxipng should check for. |
I created two images with ImageMagick and added the EXIF Orientation tag to both of them:
After compressing them with oxipng, the EXIF tags have been stripped, and the images have not been rotated. Note that neither Firefox nor Chrome currently respect this tag, and Safari only sometimes does, so these images will not be displayed correctly in your browser.
https://bugzilla.mozilla.org/show_bug.cgi?id=1627423
https://bugs.webkit.org/show_bug.cgi?id=210021
The text was updated successfully, but these errors were encountered: