Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin improvements #3641

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Conversation

RostislavKreisinger
Copy link
Contributor

@RostislavKreisinger RostislavKreisinger commented Dec 5, 2024

Description, the reason for the PR

Performace improvements:

  • Modified grid so that adding NULL FIRST / NULLS LAST is optional now, because it is much more time-consuming for huge collections.
  • QueryBuilderWithRowManipulatorDataSource called callback for each item separately without the possibility of working with all items. Modified callback so that instead of calling ID = X for each item, ID IN (X, X, X) could be called only once. In Callback function it is possible to request the entire result from query as second parameter.
  • Product grid: the query is modified to return only the data that will be displayed later. Instead of entity, the associated array is returned.
  • new Trigram indexes were added on columns using LIKE conditions in Product, Order and Customer grids.

License Agreement for contributions


🌐 Live Preview:

Copy link

coderabbitai bot commented Dec 5, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RostislavKreisinger RostislavKreisinger force-pushed the rk-ssp-2460-breno-admin-improvements branch from af5d962 to 75ca8fb Compare December 12, 2024 09:03
@vitek-rostislav vitek-rostislav added Performance Performance DX & Refactoring Requests for DX improvements and refactorings labels Dec 13, 2024
docs/administration/grid-data-sources.md Outdated Show resolved Hide resolved
docs/administration/grid-data-sources.md Outdated Show resolved Hide resolved
upgrade-notes/backend_20241205_151830.md Outdated Show resolved Hide resolved
@vitek-rostislav
Copy link
Contributor

vitek-rostislav commented Dec 23, 2024

@vitek-rostislav vitek-rostislav changed the title [SSP-2460] admin improvements admin improvements Jan 10, 2025
@vitek-rostislav vitek-rostislav changed the base branch from 16.0 to 17.0 January 14, 2025 16:25
@vitek-rostislav vitek-rostislav force-pushed the rk-ssp-2460-breno-admin-improvements branch 2 times, most recently from e11269c to de57340 Compare January 14, 2025 16:28
Rostislav Kreisinger added 6 commits January 14, 2025 17:50
…DataSource.

- When setting a null value in the hint, the slicing will behave according to the automatic settings of PostgeSQL. In cases where you are working with large datasets or complex queries (e.g. with several joined tables), working with NULL values and their order may play a role.
@vitek-rostislav vitek-rostislav force-pushed the rk-ssp-2460-breno-admin-improvements branch from de57340 to 9b6d16b Compare January 14, 2025 16:50
@vitek-rostislav vitek-rostislav merged commit d804c79 into 17.0 Jan 14, 2025
30 checks passed
@vitek-rostislav vitek-rostislav deleted the rk-ssp-2460-breno-admin-improvements branch January 14, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX & Refactoring Requests for DX improvements and refactorings Performance Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants