Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading to directory with correct permissions #3225

Open
wants to merge 5 commits into
base: 15.0
Choose a base branch
from
Open

Uploading to directory with correct permissions #3225

wants to merge 5 commits into from

Conversation

malyMiso
Copy link
Contributor

@malyMiso malyMiso commented Jun 14, 2024 •
edited by github-actions bot
Loading

Q A
Description, reason for the PR Check for existing directory before uploading to a directory. Otherwise filesystem can create directory on its own with wrong permission(700) and uploaded file will be no accessible
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

malyMiso added 3 commits June 14, 2024 14:35
@malyMiso
check for existing directory before uploading to it
a494f4c
@malyMiso
add domain as new image type
093757e 
- icons from domains are stored in `web/content/images/domains`
- a programmer sees from definition, that this type is used already
- `dirs-create` creates directory for domain icons with correct permissions
@malyMiso
create dirs while running db-demo
ca999fc 
- most of the time we run only db-demo to update data fixtures
- when there is a new image type and only db-demo is run, image data fixtures creates a directory with permission 700. This commit prevents from setting wrong permission
@malyMiso
Copy link
Contributor Author

malyMiso commented Jun 17, 2024 •
edited
Loading

Not complete solution yet. Few colleagues have reported a problem, when running dirs-create, it only created first level directory, e.g. brand. When uploading file, upload failed on UploadDirectoryNotFoundException, beacuse brand\original directory was missing.

  1. we removed web/content/brand
  2. run dirs-create
  3. web/content/brand was created with 755 permissions
  4. check failed on UploadDirectoryNotFoundException, it looked for web/content/brand/original
  5. removed check for existing directory
  6. uploaded file, upload worked, but created directory web/content/brand/original with 700 permissions

@malyMiso
Copy link
Contributor Author

Pushed new solution. Create a directory with correct permissions, when the directory is missing.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 20, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
In Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malyMiso @pk16011990