Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile vs. project-base Makefile #3726

Open
thirdknown opened this issue Jan 9, 2025 · 0 comments
Open

Makefile vs. project-base Makefile #3726

thirdknown opened this issue Jan 9, 2025 · 0 comments

Comments

@thirdknown
Copy link
Contributor

thirdknown commented Jan 9, 2025 •
edited
Loading

pnpm vs. npm

Makefile:
docker compose exec storefront pnpm run gql (https://github.com/shopsys/shopsys/blob/17.0/Makefile#L7)

project-base.Makefile:
docker compose exec storefront npm run gql (https://github.com/shopsys/shopsys/blob/17.0/project-base/Makefile#L7)

Is difference between using pnpm and npm correct?

All Makefiles should be generated from one source

Makefiles should be generated files from one "parametrized" source, because of existing not-wanted differences (pnpm vs. npm) and wrong paths (#3725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thirdknown