Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptographic randomness, updated tests, readme typos #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meepzh
Copy link

@meepzh meepzh commented Mar 8, 2017

  • Instead of Math.random(), it uses crypto.randomBytes() as suggested in issue Math.random is insecure #1.
  • The tests also broke from returning the assert statement, which expected a then clause. This was fixed with explicit return statements.
  • Also some minor typos were fixed, including the number of words in the word list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant