feat: set the cache if repo not found or has no star. This reduces AP…

…I call
shengwang52005 · Aug 27, 2023 · e1f9f39 · e1f9f39
1 parent 3b66c57
commit e1f9f39
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 13 deletions.
diff --git a/common/chart.ts b/common/chart.ts
@@ -5,6 +5,9 @@ import utils from "./utils";
 
 export const DEFAULT_MAX_REQUEST_AMOUNT = 15;
 
+const STAR_HISTORY_LOGO_URL =
+  "https://avatars.githubusercontent.com/u/124480067";
+
 export const getReposStarData = async (
   repos: string[],
   token = "",
@@ -112,6 +115,24 @@ export const getRepoData = async (
         message = "Some unexpected error happened, try again later";
       }
 
+      console.error("Failed to request data:", status, message);
+
+      // If encountering not found or no star error, we will return an empty image so that cache can be set.
+      if (status === 404 || status === 501) {
+        return [
+          {
+            repo,
+            starRecords: [
+              {
+                date: utils.getDateString(Date.now(), "yyyy/MM/dd"),
+                count: 0,
+              },
+            ],
+            logoUrl: STAR_HISTORY_LOGO_URL,
+          },
+        ];
+      }
+
       return Promise.reject({
         message,
         status,

diff --git a/packages/xy-chart/index.ts b/packages/xy-chart/index.ts
@@ -120,7 +120,7 @@ const XYChart = (
   initialOptions: Partial<XYChartOptions>
 ) => {
   const options: XYChartOptions = {
-    ...(theme === 'dark' ? getDarkThemeDefaultOptions() : getDefaultOptions()),
+    ...(theme === "dark" ? getDarkThemeDefaultOptions() : getDefaultOptions()),
     ...initialOptions,
   };
 

diff --git a/server/main.ts b/server/main.ts
@@ -81,12 +81,6 @@ const startServer = async () => {
         const message =
           error.message || "Some unexpected error happened, try again later";
 
-        if (status === 404) {
-          // do nth, repo from user not found.
-        } else {
-          logger.error("Failed to request data", error);
-        }
-
         ctx.status = status;
         ctx.message = `${http.STATUS_CODES[status]}: ${message}`;
         return;

diff --git a/server/pnpm-lock.yaml b/server/pnpm-lock.yaml
diff --git a/src/components/StarChartViewer.vue b/src/components/StarChartViewer.vue
@@ -206,11 +206,13 @@ const fetchReposData = async (repos: string[]) => {
   const repoData: RepoData[] = [];
   for (const repo of repos) {
     const cachedRepo = state.repoCacheMap.get(repo);
-    repoData.push({
-      repo,
-      starRecords: cachedRepo!.starData,
-      logoUrl: cachedRepo!.logoUrl,
-    });
+    if (cachedRepo) {
+      repoData.push({
+        repo,
+        starRecords: cachedRepo.starData,
+        logoUrl: cachedRepo.logoUrl,
+      });
+    }
   }
 
   if (repoData.length === 0) {