HBASE-19262 Revisit checkstyle rules

shadow-tx · Nov 16, 2017 · d4babbf · d4babbf
1 parent 600fdee
commit d4babbf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
@@ -33,5 +33,6 @@
 <suppressions>
   <suppress checks="." files=".*/generated/.*\.java"/>
   <suppress checks="." files=".*/generated-jamon/.*\.java"/>
-  <suppress checks="MagicNumberCheck" files=".*Test\.java"/>
+  <suppress checks="MagicNumberCheck" files=".*/src/test/.*\.java"/>
+  <suppress checks="VisibilityModifier" files=".*/src/test/.*\.java"/>
 </suppressions>
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
@@ -67,6 +67,7 @@
     http://checkstyle.sourceforge.net/config_imports.html -->
     <module name="AvoidStarImport"/>
     <module name="ImportOrder">
+      <property name="groups" value="*,org.apache.hadoop.hbase.shaded"/>
       <property name="option" value="top" />
       <property name="ordered" value="true"/>
       <property name="sortStaticImportsAlphabetically" value="true"/>