Skip to content

Commit

Permalink
HBASE-14829 Add more checkstyles (appy)
Browse files Browse the repository at this point in the history
  • Loading branch information
@saintstack
saintstack committed Nov 20, 2015
1 parent ea48ef8 commit 62aba61
Show file tree
Hide file tree
Showing 2 changed files with 61 additions and 19 deletions.
76 changes: 59 additions & 17 deletions hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,34 +32,76 @@
<module name="Checker">
<module name="FileTabCharacter"/>
<module name="TreeWalker">

<!-- Annotations Checks
http://checkstyle.sourceforge.net/config_annotation.html -->
<module name="MissingDeprecated"/>

<!-- Block Checks
http://checkstyle.sourceforge.net/config_blocks.html -->
<module name="EmptyBlock"/>
<module name="LeftCurly"/>
<module name="NeedBraces"/>

<!-- Class Design Checks
http://checkstyle.sourceforge.net/config_design.html -->
<module name="FinalClass"/>
<module name="HideUtilityClassConstructor"/>
<module name="InterfaceIsType"/>
<module name="VisibilityModifier">
<property name="packageAllowed" value="true"/>
<property name="protectedAllowed" value="true"/>
</module>

<!-- Coding Checks
http://checkstyle.sourceforge.net/config_coding.html -->
<module name="ArrayTypeStyle"/>
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="IllegalInstantiation"/>
<module name="InnerAssignment"/>
<module name="MissingSwitchDefault"/>
<module name="NoFinalizer"/>

<!-- Import Checks
http://checkstyle.sourceforge.net/config_imports.html -->
<module name="AvoidStarImport"/>
<module name="ImportOrder">
<property name="groups" value="*,javax,java"/>
<property name="ordered" value="true"/>
<property name="separated" value="true"/>
<property name="option" value="bottom"/>
<property name="sortStaticImportsAlphabetically" value="true"/>
</module>
<module name="RedundantImport"/>
<module name="UnusedImports">
<property name="processJavadoc" value="true"/>
</module>

<!-- Javadoc Checks
http://checkstyle.sourceforge.net/config_javadoc.html -->
<module name="JavadocTagContinuationIndentation"/>
<module name="NonEmptyAtclauseDescription"/>

<!-- Miscellaneous Checks
http://checkstyle.sourceforge.net/config_misc.html -->
<module name="UpperEll"/>
<module name="Indentation">
<property name="basicOffset" value="2"/>
<property name="caseIndent" value="2"/>
</module>

<!-- Size Violation Checks
http://checkstyle.sourceforge.net/config_sizes.html -->
<module name="LineLength">
<property name="max" value="100"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://|org.apache.thrift.|com.google.protobuf.|hbase.protobuf.generated"/>
</module>
<module name="MethodLength"/>

<!-- Whitespace Checks
http://checkstyle.sourceforge.net/config_whitespace.html -->
<module name="MethodParamPad"/>
<module name="ParenPad"/>
<module name="EmptyStatement"/>
<module name="EmptyBlock"/>
<module name="EqualsHashCode"/>
<module name="IllegalInstantiation"/>
<module name="InnerAssignment"/>
<module name="MissingSwitchDefault"/>
<module name="FinalClass"/>
<module name="HideUtilityClassConstructor"/>
<module name="InterfaceIsType"/>
<module name="VisibilityModifier">
<property name="packageAllowed" value="true"/>
<property name="protectedAllowed" value="true"/>
</module>
<module name="ArrayTypeStyle"/>
<module name="UpperEll"/>
<module name="NoFinalizer"/>
<module name="MissingDeprecated"/>
</module>
</module>
4 changes: 2 additions & 2 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.16</version>
<version>2.17</version>
<dependencies>
<dependency>
<groupId>org.apache.hbase</groupId>
Expand Down Expand Up @@ -2987,7 +2987,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.16</version>
<version>2.17</version>
<configuration>
<excludes>target/**</excludes>
<configLocation>hbase/checkstyle.xml</configLocation>
Expand Down

0 comments on commit 62aba61

Please sign in to comment.