Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): added details of postgres and mysql in docs #880

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

(fix): added details of postgres and mysql in docs #880

wants to merge 1 commit into from

Conversation

sahmad11
Copy link
Contributor

@sahmad11 sahmad11 commented Apr 4, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I have added examples of how to run create_db_report on Postgres and mysql databases by using SQLAlchemy in addition to the already added SQLite example to the documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #880 (a91d211) into develop (e3a7d22) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #880   +/-   ##
========================================
  Coverage    56.06%   56.07%           
========================================
  Files          314      314           
  Lines        20451    20451           
========================================
+ Hits         11465    11467    +2     
+ Misses        8986     8984    -2
Impacted Files Coverage Δ
dataprep/eda/distribution/render.py 91.06% <0.00%> (+0.10%) ⬆️
dataprep/eda/distribution/compute/overview.py 94.05% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e50232...a91d211. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sahmad11