Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/bazel-skylib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: sfreilich/bazel-skylib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 9 files changed
  • 2 contributors

Commits on Sep 29, 2021

  1. Improve escaping in unittest failure message

    daf5137 fixed a bug where the failure message would not be printed
    correctly if it included values subject to shell variable expansion
    (e.g. "$FOO") by quoting the limit string for the heredoc the message
    ("cat <<'EOF'"). However, it still left an issue if that limit string
    appeared on its own line in a message, which would happen if a compared
    value included "\nEOF\n". (Plausible if the function under test
    generated shell script code.) This could be worked around by choosing
    a more unusual string, but that remains an odd implementation detail.
    Instead, the shell implementation could use the same path of splitting
    the output into lines, echoing each line, and backslash-escaping each
    character.
    
    The previous code also did not split the error output into lines
    correctly if individual failure messages contained newlines (which
    could happen when comparing values where at least one was a string
    containing a newline; the code that generates the error message
    converts with "%s" (str)). This matters if those lines are joined
    with something other than "\n", which was the case in the Windows
    implementation (and now is the case with both).
    
    The Windows implementation also did not avoid variable expansion
    by escaping "%" as "%%" if the error message included "%".
    sfreilich committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    dba494d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Configuration menu
    Copy the full SHA
    e6f188c View commit details
    Browse the repository at this point in the history
  2. Update generated docs

    tetromino committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    929c20d View commit details
    Browse the repository at this point in the history
Loading