Skip to content

Commit

Permalink
Bug 1888683 - Upgrade UniFFI to 0.27.1. r=markh,janerik,glandium,supp…
Browse files Browse the repository at this point in the history
…ly-chain-reviewers,mach-reviewers,android-reviewers,kaya

Update:
  - UniFFI to 0.27.1
  - Glean to 59.0.0
  - App-services to a recent version

This removes the need for the goblin build hack, although we still have
duplicate versions of goblin since UniFFI is ahead of the moz-central
version.  I think that should be easy to resolve as a follow-up.

Updating uniffi-bindget-gecko-js based on upstream changes:
  - Clone objects before lowering them
    (mozilla/uniffi-rs#1880)
  - Use u64 for the RustBuffer length and capacity field
    (mozilla/uniffi-rs#1978)

I didn't implement the new callback interface VTable code.  Instead I
simply disabled the one fixture that tests it.  I'd rather implement
https://bugzilla.mozilla.org/show_bug.cgi?id=1888668 first, since that
will simplify the process a bunch. The only real-world use-case for
callbacks that I know of is Mark's logging changes, but that will
require implementing trait interfaces anyways so I'd rather wait than
write a bunch of C++ code that we then throw away.

Differential Revision: https://phabricator.services.mozilla.com/D206130
  • Loading branch information
bendk authored and web-flow committed Apr 14, 2024
1 parent 4b6bb37 commit dbf5fc5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions servo-tidy.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ packages = [
# transition to syn 2 is underway.
"syn",
"synstructure",
# Requires an update to clap v4
"textwrap",
# Can be fixed by removing time dependency - see bug 1765324
"wasi",
]
Expand Down
2 changes: 1 addition & 1 deletion webrender/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ svg_fmt = "0.4"
tracy-rs = "0.1.2"
derive_more = { version = "0.99", default-features = false, features = ["add_assign"] }
etagere = "0.2.6"
glean = { version = "58.1.0", optional = true }
glean = { version = "59.0.0", optional = true }
firefox-on-glean = { version = "0.1.0", optional = true }
swgl = { path = "../swgl", optional = true }
topological-sort = "0.1"
Expand Down
2 changes: 1 addition & 1 deletion wr_glyph_rasterizer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ tracy-rs = "0.1.2"
log = "0.4"
lazy_static = "1"
fxhash = "0.2.1"
glean = { version = "58.1.0", optional = true }
glean = { version = "59.0.0", optional = true }
firefox-on-glean = { version = "0.1.0", optional = true }
serde = { optional = true, version = "1.0", features = ["serde_derive"] }

Expand Down

0 comments on commit dbf5fc5

Please sign in to comment.