Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve integration tests #199

Closed
serpro69 opened this issue Oct 4, 2023 · 0 comments · Fixed by #238
Closed

Improve integration tests #199

serpro69 opened this issue Oct 4, 2023 · 0 comments · Fixed by #238
Labels
core 🧬 Issue related to :core module good first issue 🔰 Good for newcomers

Comments

@serpro69
Copy link
Owner

serpro69 commented Oct 4, 2023 •
edited
Loading

While working on #197 I've discovered a bunch of bugs in sub-provider functions (most were missing primary key) (see d848491#diff-0c0f72286003cc6bcebac97dd91d248f85214081533ccaf7c6921b79fcf8c9c9 for example )

This wasn't caught by integration tests because those do not trigger functions in sub-providers, hence it should be improved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core 🧬 Issue related to :core module good first issue 🔰 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve integration tests to call sub-provider functions serpro69/kotlin-faker
1 participant
@serpro69