Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish nullable. now enabled globally #1729

Merged
merged 8 commits into from
Aug 25, 2022
Merged

Finish nullable. now enabled globally #1729

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9470c2d
nullable in LogEventProperty
SimonCropp Aug 23, 2022
7d90e16
nullable in JsonValueFormatter
SimonCropp Aug 23, 2022
dde60cb
nullable in EventProperty
SimonCropp Aug 23, 2022
641371e
nullable in LogContext
SimonCropp Aug 23, 2022
9e90337
Merge branch 'dev' into temp
SimonCropp Aug 23, 2022
ad29016
enable nullable for EnricherStack
SimonCropp Aug 23, 2022
65fcf30
remove "#nullable enable" and enable globally
SimonCropp Aug 23, 2022
ef82617
Update Logger.cs
SimonCropp Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nullable in EventProperty
  • Loading branch information
@SimonCropp
SimonCropp committed Aug 23, 2022
commit dde60cb2e71d12fae8229d6534541ea31b742138
3 changes: 2 additions & 1 deletion src/Serilog/Events/EventProperty.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#nullable enable
using System;

namespace Serilog.Events
Expand Down Expand Up @@ -67,7 +68,7 @@ public void Deconstruct(out string name, out LogEventPropertyValue value)
}

/// <inheritdoc />
public override bool Equals(object obj)
public override bool Equals(object? obj)
{
return obj is EventProperty other && Equals(other);
}
Expand Down