naming, linting

serilog · Oct 30, 2024 · abf32a1 · abf32a1
1 parent 29137db
commit abf32a1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/Serilog/Capturing/PropertyValueConverter.cs b/src/Serilog/Capturing/PropertyValueConverter.cs
@@ -206,6 +206,7 @@ IEnumerable<KeyValuePair<ScalarValue, LogEventPropertyValue>> MapToDictionaryEle
                 }
             }
 
+            // To handle multidimensional arrays.
             if (value is Array array && array.Rank > 1)
             {
                 result = BuildArrayValue(array, new int[array.Rank], 0, destructuring);

diff --git a/test/Serilog.Tests/Core/LoggerTests.cs b/test/Serilog.Tests/Core/LoggerTests.cs
@@ -319,39 +319,39 @@ public void NullMessageTemplateParametersDoNotBreakBinding()
 
     // https://github.com/serilog/serilog/issues/2019
     [Fact]
-    public void Two_Dimensional_Array_Should_Be_Logger_As_Sequence()
+    public void TwoDimensionalArrayShouldBeLoggedAsSequence()
     {
         var evt = DelegatingSink.GetLogEvent(l =>
         {
             var a = new object[3, 2] { { "a", "b" }, { "c", "d" }, { "e", "f" } };
             l.Error("{@Value}", a);
         });
 
-        Assert.Equal(1, evt.Properties.Count);
+        Assert.Single(evt.Properties);
         var arr = (SequenceValue)evt.Properties["Value"];
         Assert.Equal(3, arr.Elements.Count);
         Assert.Equal("[[a,b],[c,d],[e,f]]", arr.LiteralValue());
     }
 
     // https://github.com/serilog/serilog/issues/2019
     [Fact]
-    public void Three_Dimensional_Array_Should_Be_Logger_As_Sequence()
+    public void ThreeDimensionalArrayShouldBeLoggedAsSequence()
     {
         var evt = DelegatingSink.GetLogEvent(l =>
         {
             var a = new object[3, 2, 1] { { { "a" }, { "b" } }, { { "c" }, { "d" } }, { { "e" }, { "f" } } };
             l.Error("{@Value}", a);
         });
 
-        Assert.Equal(1, evt.Properties.Count);
+        Assert.Single(evt.Properties);
         var arr = (SequenceValue)evt.Properties["Value"];
         Assert.Equal(3, arr.Elements.Count);
         Assert.Equal("[[[a],[b]],[[c],[d]],[[e],[f]]]", arr.LiteralValue());
     }
 
     // https://github.com/serilog/serilog/issues/2019
     [Fact]
-    public void Four_Dimensional_Array_Should_Be_Logged_As_Sequence()
+    public void FourDimensionalArrayShouldBeLoggedAsSequence()
     {
         var evt = DelegatingSink.GetLogEvent(l =>
         {
@@ -381,15 +381,15 @@ public void Four_Dimensional_Array_Should_Be_Logged_As_Sequence()
             l.Error("{@Value}", a);
         });
 
-        Assert.Equal(1, evt.Properties.Count);
+        Assert.Single(evt.Properties);
         var arr = (SequenceValue)evt.Properties["Value"];
         Assert.Equal(2, arr.Elements.Count);
         Assert.Equal("[[[[a,b],[c,d]],[[e,f],[g,h]]],[[[i,j],[k,l]],[[m,n],[o,p]]]]", arr.LiteralValue());
     }
 
     // https://github.com/serilog/serilog/issues/2019
     [Fact]
-    public void Empty_Multi_Dimensional_Arrays_Should_Be_Serialized() // Same behaviour as Newtonsoft.Json
+    public void EmptyMultiDimensionalArraysShouldBeSerializedProperly() // Same behaviour as Newtonsoft.Json
     {
         var evt = DelegatingSink.GetLogEvent(l =>
         {
@@ -410,7 +410,7 @@ public void Empty_Multi_Dimensional_Arrays_Should_Be_Serialized() // Same behavi
 
     // https://github.com/serilog/serilog/issues/2019
     [Fact]
-    public void JaggedArray_Should_Respect_MaximumCollectionCount()
+    public void JaggedArrayShouldRespectMaximumCollectionCount()
     {
         // Arrange
         var collectingSink = new CollectingSink();
@@ -449,7 +449,7 @@ public void JaggedArray_Should_Respect_MaximumCollectionCount()
 
     // https://github.com/serilog/serilog/issues/2019
     [Fact]
-    public void MultiDimensionalArray_Should_Respect_MaximumCollectionCount()
+    public void MultiDimensionalArrayShouldRespectMaximumCollectionCount()
     {
         // Arrange
         var collectingSink = new CollectingSink();
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                 }
+                // To handle multidimensional arrays.
                 if (value is Array array && array.Rank > 1)
                 {
                     result = BuildArrayValue(array, new int[array.Rank], 0, destructuring);
@@ Expand Down @@