Some edits after reviewing latest changes (#2028)

serilog · Oct 25, 2024 · 7af255d · 7af255d
1 parent 12c24a5
commit 7af255d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -2,7 +2,7 @@ root = true
 
 [*]
 trim_trailing_whitespace = true
-insert_final_newline = false
+insert_final_newline = true
 indent_style = space
 indent_size = 4
 charset = utf-8
@@ -11,6 +11,10 @@ end_of_line = lf
 [*.{csproj,json,config,yml,props}]
 indent_size = 2
 
+# Do not insert newline for ApiApprovalTests
+[*.txt]
+insert_final_newline = false
+
 [*.sh]
 end_of_line = lf
 

diff --git a/src/Serilog/Core/Pipeline/ByReferenceStringComparer.cs b/src/Serilog/Core/Pipeline/ByReferenceStringComparer.cs
@@ -39,6 +39,6 @@ public bool Equals(string? x, string? y)
 
     public int GetHashCode(string obj)
     {
-        return GetHashCode((object) obj);
+        return RuntimeHelpers.GetHashCode(obj);
     }
 }
diff --git a/src/Serilog/Rendering/ReusableStringWriter.cs b/src/Serilog/Rendering/ReusableStringWriter.cs
@@ -9,7 +9,7 @@ sealed class ReusableStringWriter : StringWriter
     static ReusableStringWriter? _pooledWriter;
 
     /// <summary>
-    /// Max capacity of StringBuilder we keep for next using
+    /// Max capacity of StringBuilder we keep for next using.
     /// </summary>
     internal const int StringBuilderCapacityThreshold = 32768;