Don't capture properties with private get accessors

serilog · Aug 26, 2024 · 68881e1 · 68881e1
1 parent 3f6d855
commit 68881e1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Serilog/Capturing/PropertyValueConverter.cs b/src/Serilog/Capturing/PropertyValueConverter.cs
@@ -397,7 +397,7 @@ internal StructureValue CreateStructureValue(object value, [DynamicallyAccessedM
         for (var i = 0; i < properties.Length; ++i)
         {
             var property = properties[i];
-            if (!property.CanRead)
+            if (property.GetMethod == null || !property.GetMethod.IsPublic)
             {
                 continue;
             }

diff --git a/test/Serilog.Tests/Capturing/PropertyValueConverterTests.cs b/test/Serilog.Tests/Capturing/PropertyValueConverterTests.cs
@@ -488,4 +488,18 @@ public class SubclassWithOverride : BaseClass
     {
         public override string Name => "override";
     }
+
+    [Fact]
+    public void PrivateGettersAreIgnoredWhenCapturing()
+    {
+        var structure = _converter.CreateStructureValue(new HasPropertyWithPrivateGetter(), typeof(HasPropertyWithPrivateGetter), false);
+        Assert.Contains(structure.Properties, p => p.Name == "A");
+        Assert.DoesNotContain(structure.Properties, p => p.Name == "B");
+    }
+
+    public class HasPropertyWithPrivateGetter
+    {
+        public string A { get; set; } = "A";
+        public string B { private get; set; } = "B";
+    }
 }