Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use makeTag from utils rather than lodash template #2814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheWolfNL
Copy link

No description provided.

@@ -1,4 +1,4 @@
import { isFunction, template, union } from "lodash-es";
import { template, union } from "lodash-es";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isFunction was imported but not used.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incase the unused function is desired

Suggested change
import { template, union } from "lodash-es";
import { isFunction, template, union } from "lodash-es";

Comment on lines 5 to +6
import { getNote, getTags } from "../../lib/git.js";
import { makeTag } from "../../lib/utils.js";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the line above, but this could also be:

Suggested change
import { getNote, getTags } from "../../lib/git.js";
import { makeTag } from "../../lib/utils.js";
import { getNote, getTags } from "../git.js";
import { makeTag } from "../utils.js";

though in that manner it would lose the mention of libs and might not be as explicit / obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant