istioctl analyze: do not error if the threshold is warning (istio#27846)

sel · Oct 9, 2020 · e403231 · e403231
1 parent 239d5d7
commit e403231
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/istioctl/cmd/analyze.go b/istioctl/cmd/analyze.go
@@ -64,8 +64,8 @@ func (f FileParseError) Error() string {
 var (
 	listAnalyzers     bool
 	useKube           bool
-	failureThreshold  = formatting.MessageThreshold{diag.Warning} // messages at least this level will generate an error exit code
-	outputThreshold   = formatting.MessageThreshold{diag.Info}    // messages at least this level will be included in the output
+	failureThreshold  = formatting.MessageThreshold{diag.Error} // messages at least this level will generate an error exit code
+	outputThreshold   = formatting.MessageThreshold{diag.Info}  // messages at least this level will be included in the output
 	colorize          bool
 	msgOutputFormat   string
 	meshCfgFile       string

diff --git a/istioctl/cmd/analyze_test.go b/istioctl/cmd/analyze_test.go
@@ -53,7 +53,7 @@ func TestNoErrorIfMessageLevelsBelowThreshold(t *testing.T) {
 			"",
 		),
 		diag.NewMessage(
-			diag.NewMessageType(diag.Info, "A1", "Template: %q"),
+			diag.NewMessageType(diag.Warning, "A1", "Template: %q"),
 			nil,
 			"",
 		),
-Original file line number
+Diff line change
@@ Expand Up / @@ -53,7 +53,7 @@ func TestNoErrorIfMessageLevelsBelowThreshold(t *testing.T) { @@
     			"",
     		),
     		diag.NewMessage(
-    			diag.NewMessageType(diag.Info, "A1", "Template: %q"),
+    			diag.NewMessageType(diag.Warning, "A1", "Template: %q"),
     			nil,
     			"",
     		),
@@ Expand Down @@