Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add golangci-lint to circleci config #907

Merged
merged 12 commits into from
May 16, 2022
Merged

build: add golangci-lint to circleci config #907

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
709c8bc
build: add golangci-lint to circleci config
dominicbarnes May 6, 2022
b08dc99
refactor(golangci-lint): fix deadcode issues
dominicbarnes May 6, 2022
6170a60
refactor(golangci-lint): fix godot issues
dominicbarnes May 6, 2022
f49a09d
refactor(golangci-lint): fix gofmt issues
dominicbarnes May 6, 2022
f57e65b
refactor(golangci-lint): fix gosimple issues
dominicbarnes May 6, 2022
4137bf7
refactor(golangci-lint): fix unused issues
dominicbarnes May 13, 2022
9b2c26d
refactor(golangci-lint): fix ineffassign issues
dominicbarnes May 13, 2022
654fcb1
refactor(golangci-lint): fix staticcheck issues
dominicbarnes May 13, 2022
ada2d64
config(golangci-lint): disable errcheck, add context comments
dominicbarnes May 13, 2022
f617121
config(golangci): fix config file name for linter
dominicbarnes May 13, 2022
e02eb7b
simplify golangci-lint config, autofix
dominicbarnes May 16, 2022
f85eb3e
refactor(reader): fix staticcheck lint issue
dominicbarnes May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: add golangci-lint to circleci config
  • Loading branch information
@dominicbarnes
dominicbarnes committed May 16, 2022
commit 709c8bcb4564794ff321e2a861e4b6baa80636c5
8 changes: 8 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
version: 2
jobs:
lint:
docker:
- image: golangci/golangci-lint:v1.45-alpine
steps:
- checkout
- run: golangci-lint run

# The kafka 0.10 tests are maintained as a separate configuration because
# kafka only supported plain text SASL in this version.
kafka-010:
Expand Down Expand Up @@ -287,6 +294,7 @@ workflows:
version: 2
run:
jobs:
- lint
- kafka-010
- kafka-011
- kafka-101
Expand Down
15 changes: 15 additions & 0 deletions .golangci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
linters:
enable-all: true
disable:
- exhaustivestruct
- golint
- interfacer
- maligned
- scopelint
- testpackage

linters-settings:
errcheck:
check-type-assertions: true
check-blank: true
ignoretests: true