issue-43: [WIP] headers added #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarbo87
commented
Jan 26, 2019
| @@ -16,6 +16,12 @@ func crc32OfMessage(magicByte int8, attributes int8, timestamp int64, key []byte | |||
| } | |||
| b.writeBytes(key) | |||
| b.writeBytes(value) | |||
|
|
|||
| b.writeArray(len(headers), func(i int) { | |||
| b.writeBytes(headers[i].Key) | |||
There was a problem hiding this comment.
I tried the option when the key is a string: https://kafka.apache.org/documentation/#record
But it also does not work
|
Thanks for you contribution! We actually have another contributor who's been working on adding this as part of a bigger task to support v2 of the message format, see #163 We're close to ready to merge on that PR, please let us know if it fits your use case or if there are missing features that you'd like to see added there! |
|
thanks for the info, this is exactly what i need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to implement #43 , but failed.
Messages are sent to Kafka, but there are no headers.
Have any ideas?