[STRATCONN-5445] - Fixes process consent casing in DV360 Actions #2712
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2712 +/- ##
==========================================
+ Coverage 78.46% 78.50% +0.03%
==========================================
Files 1036 1036
Lines 18771 18772 +1
Branches 3561 3561
==========================================
+ Hits 14729 14737 +8
+ Misses 2844 2836 -8
- Partials 1198 1199 +1 ☔ View full report in Codecov by Sentry. |
itsarijitray
approved these changes
Feb 4, 2025
marinhero
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes casing of process consent boolean flag from snake case to camel case so that it gets processed by protobuf lib properly. Currently our customers have raised concerns that process consent flag is not being set properly (JIRA).
Probuf lib we use expect us to use lowerCamelCase for fields (ref).
Testing
Tested successfully in staging for positive scenario
Added unit tests to ensure processConsent is set. Similar toBinary, toJSON serializes class based on contract.
Before
toJSON didn't include processConsent
After
toJSON includes processConsent
This change is not expected to cause any regression as this feature wasn't working before.