Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Dockerfile #245

Merged
merged 8 commits into from
Sep 26, 2018
Merged

refactor Dockerfile #245

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b193fc6
ignore the temporary image file used for builds
andrewhsu Sep 25, 2018
e1c5495
git ignore gosec binary
andrewhsu Sep 25, 2018
291a6e7
no need for GOPATH in the Dockerfile
andrewhsu Sep 25, 2018
a81f338
no need for GOROOT in Dockerfile
andrewhsu Sep 25, 2018
d12f53c
bump Dockerfile golang to 1.10.4
andrewhsu Sep 25, 2018
2c7e0a4
replace docker-entrypoint.sh with the gosec binary
andrewhsu Sep 25, 2018
f859701
refactor Dockerfile into multi-stage
andrewhsu Sep 25, 2018
b24e3ef
fix the image execution example in README.md
andrewhsu Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
no need for GOPATH in the Dockerfile 
It is already set in the golang:1.10.3-alpine3.8 image.

Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
  • Loading branch information
@andrewhsu
andrewhsu committed Sep 25, 2018
commit 291a6e7adf3f194a7058958106a7102bcfc5dc45
1 change: 0 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ FROM golang:1.10.3-alpine3.8

ENV BIN=gosec
ENV GOROOT=/usr/local/go
ENV GOPATH=/go

COPY $BIN /go/bin/$BIN
COPY docker-entrypoint.sh /usr/local/bin
Expand Down