Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against prod TF #895

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Test against prod TF #895

merged 2 commits into from
Jan 21, 2025

Conversation

uri-granta
Copy link
Collaborator

@uri-granta uri-granta commented Jan 21, 2025 •
edited
Loading

Related issue(s)/PRs:

Summary

We currently test against the oldest and latest versions of tensorflow that we support. Add tests against an intermediate "prod" version.

Fully backwards compatible: yes / no

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@uri-granta uri-granta marked this pull request as ready for review January 21, 2025 11:19
hstojic
hstojic approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@uri-granta uri-granta merged commit e0ca784 into develop Jan 21, 2025
16 checks passed
@uri-granta uri-granta deleted the uri/test_tf_2_14 branch January 21, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstojic hstojic hstojic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @hstojic