Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SafeModeScope import #892

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Fix SafeModeScope import #892

merged 3 commits into from
Jan 20, 2025

Conversation

uri-granta
Copy link
Collaborator

@uri-granta uri-granta commented Jan 20, 2025 •
edited
Loading

Related issue(s)/PRs:

Summary

Fix SafeModeScope import to work with TF 2.14.

Testing against TF 2.14 will follow in a later PR after GPflow has been updated (currently blocked by this weirdness).

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@uri-granta uri-granta marked this pull request as ready for review January 20, 2025 11:39
qiq208
qiq208 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@qiq208 qiq208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uri-granta uri-granta merged commit 397a35d into develop Jan 20, 2025
12 checks passed
@uri-granta uri-granta deleted the uri/fix_safemode_import branch January 20, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiq208 qiq208 qiq208 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @qiq208