Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use past prices to convert past balances #190

Open
bunburya opened this issue Dec 3, 2021 · 1 comment
Open

Use past prices to convert past balances #190

bunburya opened this issue Dec 3, 2021 · 1 comment

Comments

@bunburya
Copy link

bunburya commented Dec 3, 2021

Currently it seems the latest available price is always used to convert the balance of an account to a different currency, even if we are looking for the balance at some date in the past. This makes it difficult to accurately depict the balance of accounts on dates in the past if they are foreign currency or non-cash accounts.

It would be nice if, when getting an account balance as of a date in the past, we had the option to use the available price that is closest in time to that date.

I would be happy to work on a PR for this when I have time, if there is no objection to including this feature.

@sdementen
Copy link
Owner

no objection to include this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants