Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N: Miscellaneous fixes #6305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ccawley2011
Copy link
Member

This is complicated by the fact that there appear to be two Traditional Chinese translations - one that's empty but has a more descriptive language ID, and one that's 20% complete but is broken by the first commit which uses zh_Hant as the language ID in the theme files.

I'm also not sure if the second commit should have been done via Weblate instead, but I couldn't spot an easy way of doing it.

@ccawley2011 ccawley2011 assigned criezy and unassigned criezy Dec 10, 2024
@ccawley2011 ccawley2011 requested a review from criezy December 10, 2024 15:15
@criezy
Copy link
Member

criezy commented Dec 10, 2024

I am wondering if there is a reason to have two traditional chinese translation.
But couldn't we have all three "zh", "zh_Hans", and "zh_Hant" in the themes?

The second commit is fine. The "X-Language-name" is an extension and not part of the standard header. Weblate preserves it but doesn't set it. And we indeed use it in ScummVM if defined.

@ccawley2011
Copy link
Member Author

I am wondering if there is a reason to have two traditional chinese translation. But couldn't we have all three "zh", "zh_Hans", and "zh_Hant" in the themes?

I'm guessing that "zh_Hant" was intended to be a rename of the older "zh" to reduce ambiguity between the Traditional and Simplified translations when the latter was added. Since "zh_Hant" is empty it should still be relatively simple to remove it and rename the "zh" translation, I'm just not sure how to do that without disrupting Weblate.

@criezy
Copy link
Member

criezy commented Dec 10, 2024

I'm guessing that "zh_Hant" was intended to be a rename of the older "zh" to reduce ambiguity between the Traditional and Simplified translations when the latter was added.

Since zh_Hant and zh_Hans were added on the same day that is probably a good guess.

Since "zh_Hant" is empty it should still be relatively simple to remove it and rename the "zh" translation, I'm just not sure how to do that without disrupting Weblate.

I think we will need to do that manually, but lock Weblate during the process for safety. I will do that after your changes are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants