Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snap! list icon #390

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Add Snap! list icon #390

merged 4 commits into from
Oct 21, 2021

Conversation

CST1229
Copy link
Contributor

@CST1229 CST1229 commented Sep 12, 2021

Resolves #340

Adds the Snap! list icon, created using @list:
test
(That's really all I have to say... But I got #390! That means only 10 more until the 400 milestone.)

@tjvr
Copy link
Member

tjvr commented Sep 12, 2021

Thanks for this!

Could you please share a screenshot of Snap! for comparison? 🙏

Copy link
Member

@tjvr tjvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! I just want to check the output is close enough 👍

@CST1229
Copy link
Contributor Author

CST1229 commented Sep 12, 2021

Could you please share a screenshot of Snap! for comparison? 🙏

Snap!: scratchblocks:

Snap!: scratchblocks:

@DragonEggFish
Copy link

support
it looks much cleaner

@DragonEggFish
Copy link

and will its opcode have @listIcon

@CST1229
Copy link
Contributor Author

CST1229 commented Sep 14, 2021

and will its opcode have @listIcon

No, I have set it as @list.
Also this is a pull request, not a suggestion.

@DragonEggFish
Copy link

okie

@CST1229
Copy link
Contributor Author

CST1229 commented Sep 26, 2021

@tjvr Any updates on this? I have provided the Snap! icons, for comparison.

Copy link
Member

@tjvr tjvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these look great! Sorry for the delay 🙇

@tjvr tjvr merged commit be8d633 into scratchblocks:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap list icon
3 participants