Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes OpenShift 4 test for postgresql-container #499

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented Feb 28, 2023

This pull request fixes OpenShift 4 tests.

What is changed:

  • container-common-scripts are updated
  • added tests run_latest_imagestreams_test
  • test test_postgresql_integration checks as ephemeral-template as persistent-template

@phracek
Copy link
Member Author

phracek commented Feb 28, 2023

This pull request modifies only OpenShift test. Let's only test them.

[test-openshift]

Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. Please see my comments.

test/test-lib-postgresql.sh Show resolved Hide resolved
test/test-lib-postgresql.sh Show resolved Hide resolved
test/postgresql-persistent-template.json Outdated Show resolved Hide resolved
@phracek
Copy link
Member Author

phracek commented Feb 28, 2023

[test-openshift]

@zmiklank
Copy link
Contributor

zmiklank commented Mar 1, 2023

[test]

@phracek
Copy link
Member Author

phracek commented Mar 1, 2023

OpenShift tests are passing. The container tests are not valid for this pull request. It should be solved by #366 .

phracek added 3 commits March 1, 2023 15:28
…ing.

Check run_latest_imagestreams.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the fixes_openshift_4 branch from 47aa172 to 29f518a Compare March 1, 2023 14:30
@phracek
Copy link
Member Author

phracek commented Mar 1, 2023

This pull request fixes OpenShift 4 tests. Container tests are not needed to run.

[test-openshift]

@phracek
Copy link
Member Author

phracek commented Mar 2, 2023

Let's re-run one more time

[test-openshift]

@phracek
Copy link
Member Author

phracek commented Mar 7, 2023

Subscriptions should be now solved.

[test-openshift]

@phracek phracek merged commit bc215c8 into master Mar 7, 2023
@zmiklank zmiklank deleted the fixes_openshift_4 branch November 23, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants