Skip to content

Merge cmake branch into master #65

Open
@tromer

Description

We want to transition libsnark to CMake. The cmake branch mostly implements this, but its code lags a bit behind master.

We should finalize the CMake flags interface, and merge the cmake branch into master.

When finalizing the CMake flags, let's take the opportunity to remove all negations (e.g., NO_PT_COMPRESSION), and make sure all useful flags are expressed in a uniform way (currently some are Makefile proper flags and some are pass-through FEATUREFLAGS="-Dfoo".

Activity

tromer

tromer commented on Jan 31, 2017

@tromer
MemberAuthor

Correction: the cmake branch has merged #45, which is a major refactoring of the algebra and FFT into separate libraries. Merging is now messier.

chfast

chfast commented on Mar 7, 2017

@chfast

Can I help with this?

tromer

tromer commented on Mar 8, 2017

@tromer
MemberAuthor

Tentative merged version (not yet tested): https://github.com/scipr-lab/libsnark/tree/cmake-master-merging

copumpkin

copumpkin commented on Jan 20, 2018

@copumpkin

Isn't this done now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Merge cmake branch into master · Issue #65 · scipr-lab/libsnark