ENH Add sample_indices for SMOTE class #843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @tianlinhe! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue #772
What does this implement/fix? Explain your changes.
To add the sample indices of the generating samples that do not belong to the original dataset.
sample_indices()exposes the index of the original samples in a listget_which_neighbors=Truereveals from which random neighbor the sample was generated. For original data it returns 0, which means itselfAny other comments?
-[x] Changes pass PEP8 (no issue on the changed lines)
It is only implemented in SMOTE. If needed I am happy to include it in ADASYN.