RELEASE 0.19 #9502
Merged
RELEASE 0.19 #9502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n#9335) * AffinityPropagation damping factor not explained * Added for API also * Add equation for damping * formatting text * Add suggestions
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
* Too few arguments in formatting call * Add test * Covered with tests
…learn#9356) * supress deprecation warnings for non_negative option * more non_negative option deprecation warnings * fix flake8 warning
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
* DOC developer quality of life notes * rename debugging.rst to tips.rst * more tips, better internal consistency
…essor (scikit-learn#9368) * added examples to RandomForestClassifier and RandomForestRegressor * changed example for RandomForestClassifier using make_classification * changed example for RandomForestRegressor using make_regression * made more clear which features are important in examples
…eAggresiveRegressor (scikit-learn#9373)
…cess_data (scikit-learn#9347) * copy not passed from linear_model/base.py:_pre_fit to _preprocess_data in the sparse case * Pass copy as False for sparse matrix to _preprocess_data * Add comment with reason for copy=False
…ion estimators (scikit-learn#7823) * DOC Add NOTE that unless random_state is set, split will not be identical * TST use np.testing.assert_equal for nested lists/arrays * TST Make sure cv param can be a generator * DOC rank_ becomes a link when rendered * Use test_... * Remove blank line; Add if shuffle is True * Fix tests * Explicitly test for GeneratorType * TST Add the else clause * TST Add comment on usage of np.testing.assert_array_equal * TYPO * MNT Remove if ; * Address Joel's comments * merge the identical points in doc * DOC address Andy's comments * Move comment to before the check for generator type
…ession Tree Building (scikit-learn#9367) * clarified documentation for regression tree criterion * added explanation on doc/modules/tree.rst
…ree (scikit-learn#9309) * Depreciation warning for n_components in sklearn/cluster/hierarchical.py * typo fix * Whitespace fix * Update hierarchical.py * Added test * Added test-v2 * Test for deprecation * Test function name change * Updated test * Update test_hierarchical.py * fixing flake8 errors * removed blank line * modifying test * Change condition for deprecation warning * Change indentation and compare function output * fix flake8 errors * Update test_hierarchical.py
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
* Add links for [RW2006] * Update [RW2006] reference link
* Add missing mixins to ClassifierChain * Fix import in test
|
I've added some commits that I realised I'd left behind due to a failed pull on master... |
|
We need to add this #9507 and update the whatsnew accordingly. |
|
and perhaps #9259 because it's small...
…On 8 Aug 2017 7:35 pm, "Olivier Grisel" ***@***.***> wrote:
We need to add this #9507
<#9507> and update the
whatsnew accordingly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9502 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6z02iPhOj99j61lGjkv9vak-t8rVks5sWCvOgaJpZM4Ouoie>
.
|
|
Updated. Also changed release date to Wednesday...? |
|
+1 for merge. Let's make the release :) |
|
Okay, so should I put the date back to Tuesday?? :)
…On 8 August 2017 at 23:22, Olivier Grisel ***@***.***> wrote:
+1 for merge. Let's make the release :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9502 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6_sB-n-PMO1ThfYAe_INyBvVJmn2ks5sWGD7gaJpZM4Ouoie>
.
|
|
Did you do a pass over the documentation for the 0.19 branch? I have not done so yet. |
|
The changelog I've looked over. Not sure what you're looking for. But I'm off to bed. ICML is exhausting. |
|
Feel free to do what you wish with this branch. |
|
Maybe we should put the release date on Thursday:
|
|
okay :) though i thought the release date is the tag date.
…On 8 Aug 2017 11:25 pm, "Olivier Grisel" ***@***.***> wrote:
Maybe we should put the release date on Thursday:
- we need to update all the navigation menus in the doc so that the
links that have a version number are consistent
http://scikit-learn.org/0.19/
- once the tag has been pushed we will have to wait a couple of hours
to get http://github.com/MacPython/scikit-learn-wheels
<https://github.com/MacPython/scikit-learn-wheels> to build everything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9502 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6wIDUKut4GdlY-OV8_iKx-wgTQEfks5sWGHBgaJpZM4Ouoie>
.
|
|
release statistics are also missing. |
|
I went ahead an pushed those commits to the 0.19.X branch. @amueller if you have any objection please speakup as I plan to release soon otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick lots (FIX, DOC, TST) from master. Add a release date (Monday) to 0.19 what's new. Update version in
sklearn/__init__.pyPing @amueller, @ogrisel
Interactive rebase (though later I realised I'd missed some):